This fixes the handling of some FS copper SFP modules using the RollBall protocol and needing some extra treatment. Signed-off-by: Martin Schiller <ms@dev.tdt.de>
37 lines
1.5 KiB
Diff
37 lines
1.5 KiB
Diff
From 6999e0fc9a552ce98fcc66bee3dca7e55fba0ed3 Mon Sep 17 00:00:00 2001
|
|
From: Marek Behún <kabel@kernel.org>
|
|
Date: Tue, 23 Apr 2024 10:50:38 +0200
|
|
Subject: net: sfp: update comment for FS SFP-10G-T quirk
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Update the comment for the Fibrestore SFP-10G-T module: since commit
|
|
e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module")
|
|
we also do a 4 second wait before probing the PHY.
|
|
|
|
Fixes: e9301af385e7 ("net: sfp: fix PHY discovery for FS SFP-10G-T module")
|
|
Signed-off-by: Marek Behún <kabel@kernel.org>
|
|
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
|
|
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
|
|
Link: https://lore.kernel.org/r/20240423085039.26957-1-kabel@kernel.org
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/phy/sfp.c | 5 +++--
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
|
|
|
--- a/drivers/net/phy/sfp.c
|
|
+++ b/drivers/net/phy/sfp.c
|
|
@@ -454,8 +454,9 @@ static const struct sfp_quirk sfp_quirks
|
|
SFP_QUIRK("ALCATELLUCENT", "3FE46541AA", sfp_quirk_2500basex,
|
|
sfp_fixup_long_startup),
|
|
|
|
- // Fiberstore SFP-10G-T doesn't identify as copper, and uses the
|
|
- // Rollball protocol to talk to the PHY.
|
|
+ // Fiberstore SFP-10G-T doesn't identify as copper, uses the Rollball
|
|
+ // protocol to talk to the PHY and needs 4 sec wait before probing the
|
|
+ // PHY.
|
|
SFP_QUIRK_F("FS", "SFP-10G-T", sfp_fixup_fs_10gt),
|
|
|
|
// Fiberstore GPON-ONU-34-20BI can operate at 2500base-X, but report 1.2GBd
|