Resneptacle/openwrt-cghmn-mt300n
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

treewide: use ethtool_puts instead of memcpy

Browse Source 
The former is a safer and more readable version.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2023-12-10 15:12:24 -08:00 committed by Christian Marangi
parent 511c7ff032
commit 89ff407d68
No known key found for this signature in database
GPG Key ID: AC001D09ADBFEAD7
4 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_ethtool.c
View File

@ -169,8 +169,7 @@ static void ag71xx_ethtool_get_strings(struct net_device *netdev, u32 sset,
int i; int i;
for (i = 0; i < ARRAY_SIZE(ag71xx_statistics); i++) for (i = 0; i < ARRAY_SIZE(ag71xx_statistics); i++)
memcpy(data + i * ETH_GSTRING_LEN, ethtool_puts(&data, ag71xx_statistics[i].name);
ag71xx_statistics[i].name, ETH_GSTRING_LEN);
} }
} }

2
target/linux/ipq40xx/patches-6.1/700-net-ipqess-introduce-the-Qualcomm-IPQESS-driver.patch
View File

@ -1953,7 +1953,7 @@ Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
+ switch (stringset) { + switch (stringset) {
+ case ETH_SS_STATS: + case ETH_SS_STATS:
+ for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++) + for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++)
+ ethtool_sprintf(&p, ipqess_stats[i].string); + ethtool_puts(&p, ipqess_stats[i].string);
+ break; + break;
+ } + }
+} +}

2
target/linux/ramips/files/drivers/net/ethernet/ralink/ethtool.c
View File

@ -161,7 +161,7 @@ static void fe_get_strings(struct net_device *dev, u32 stringset, u8 *data)
{ {
switch (stringset) { switch (stringset) {
case ETH_SS_STATS: case ETH_SS_STATS:
memcpy(data, *fe_gdma_str, sizeof(fe_gdma_str)); ethtool_puts(&data, *fe_gdma_str);
break; break;
} }
} }

3
target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/dsa.c
View File

@ -944,8 +944,7 @@ static void rtl83xx_get_strings(struct dsa_switch *ds,
return; return;
for (int i = 0; i < ARRAY_SIZE(rtl83xx_mib); i++) for (int i = 0; i < ARRAY_SIZE(rtl83xx_mib); i++)
strncpy(data + i * ETH_GSTRING_LEN, rtl83xx_mib[i].name, ethtool_puts(&data, rtl83xx_mib[i].name);
ETH_GSTRING_LEN);
} }
static void rtl83xx_get_ethtool_stats(struct dsa_switch *ds, int port, static void rtl83xx_get_ethtool_stats(struct dsa_switch *ds, int port,